Get phpcs to run without error - Githubissues

monero-integrations / monerophp

Monero PHP library + JsonRPC Client

MIT License

116 stars 76 forks source link

Get phpcs to run without error #153

Open itismadness opened 7 months ago

itismadness commented 7 months ago

Most of the changes here are a result of running vendor/bin/phpcbf, and then excluding all rules that still fail as they need to be manually fixed and better to do that in more PRs to keep this easy to review/merge. When reviewing, would encourage to click the option to ignore whitespace changes.

BrianHenryIE commented 7 months ago

This is a good idea, given the current codebase.

I think we should open an issue, something like ~"TODO: fix PHPCS exclusions".

Then hopefully we'll see PRs for each item individually.

Generic.Files.LineLength.TooLong
PEAR.Functions.ValidDefaultValue.NotAtEnd
PSR1.Classes.ClassDeclaration.MultipleClasses
PSR1.Methods.CamelCapsMethodName.NotCamelCaps
PSR2.Classes.PropertyDeclaration.ScopeMissing
PSR2.ControlStructures.SwitchDeclaration.TerminatingComment
PSR2.Methods.MethodDeclaration.Underscore
Squiz.Classes.ValidClassName.NotCamelCaps
Squiz.Scope.MethodScope.Missing

All those seem like things that should be fixed (sometimes I don't care much for some of the rules).