Set CURLOPT_HTTP09_ALLOWED to true

monero-integrations / monerophp

Monero PHP library + JsonRPC Client

MIT License

119 stars 76 forks source link

Set CURLOPT_HTTP09_ALLOWED to true #155

Open ExpDev07 opened 6 months ago

ExpDev07 commented 6 months ago

CURL allowed HTTP/0.9 responses by default before 7.66.0, but since 7.66.0, libcurl requires this option set to 1L to allow HTTP/0.9 responses. This is required for interacting with Monero wallet as it uses HTTP/0.9.

https://curl.se/libcurl/c/CURLOPT_HTTP09_ALLOWED.html

recanman commented 6 months ago

This code is old and is to be replaced by #154.

ExpDev07 commented 6 months ago

I'll just patch it until the release then @recanman.

But wouldn't this still be good to merge as it's such a small non breaking change, and we don't know when the new version is going to be replaced. If people wanna use it and have a newer cURL version, they literally can't use it without the patch.

recanman commented 6 months ago

Good point. I don't have write access and I cannot merge this.