search

monero-integrations / monerophp

Monero PHP library + JsonRPC Client
MIT License
118 stars 76 forks source link

fix encode base58 #78

Closed ibragimkb closed 6 years ago

ibragimkb commented 6 years ago

fix losing symbols '1' when encode a hexadecimal string to Base58.

Hi,

Methods _Cryptonote::integrated_addr_fromkeys() , base58::encode() return result without '1'

Code for get integrated address: gen_integaddr.txt

Results: integrated address: ref: 4DrvGduF3ynBoZ4NMDwYtN18obc8AemS33DBLWs3H7otXft3XjrpDtQGv7SqSsaBYBb98uNbr2VBBEt7f2wfn3RVPkNUtnN5hPM13TZaa4 gen: 4DrvGduF3ynBoZ4NMDwYtN8obc8AemS33DBLWs3H7otXft3XjrpDtQGv7SqSsaBYBb98uNbr2VBBEt7f2wfn3RVPkNUtnN5hPM3TZaa4

serhack commented 6 years ago

@sneurlax please review it, thanks!

sneurlax commented 6 years ago

OK, will do when I get home!

On Thu, Jul 26, 2018, 12:10 SerHack notifications@github.com wrote:

@sneurlax https://github.com/sneurlax please review it, thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/monero-integrations/monerophp/pull/78#issuecomment-408203981, or mute the thread https://github.com/notifications/unsubscribe-auth/AD6u2QQI5expfmrXIy1cCxE7MoHOqBvEks5uKhQ_gaJpZM4ViUCk .

sneurlax commented 6 years ago

Tested working.