AddressBook: move subscription saving to storage

coneiric commented 6 years ago

Save subscriptions based on type, and move I/O to AddressBookStorage. ~~~Makes the default hosts.txt read-only.~~~

Resolves #1006

By submitting this pull-request, I confirm the following:

I have read and understood the developer guide in kovri-docs.
I have checked that another pull-request for this purpose does not exist.
I have considered and confirmed that this submission will be valuable to others.
I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
I give this submission freely under the BSD 3-clause license.

coneiric commented 6 years ago

As I've said to you several times already, there is no plan to implement any PGP verification.

Removed it.

Note: the fix is much simpler

This also resolves the TODO in the code to move storage to the AddressBookStorage class. If you would like me to split the PR in two, I can.

anonimal commented 6 years ago

NOTICE: THIS PULL REQUEST HAS BEEN MOVED TO GitLab. Please reopen there if you wish to merge. See https://github.com/monero-project/kovri/issues/1013 for details.

monero-project / kovri