search

monero-project / mininero

A Python reimplementation of the one-time ring signatures as found in Monero
Other
74 stars 41 forks source link

"checksig" test always pass even when it should not #1

Open binaryFate opened 9 years ago

binaryFate commented 9 years ago

The "checksig" test in mininero.py always pass, even if the private key is arbitrarily changed.

For instance, when changing the private key before signing, like this on line 700: sir, sic = generate_signature(prefix, pub, 99999999999999999999999999999999999999999999999999999999999999999999999999999)

check_signature() still returns True.

ghost commented 9 years ago

Dear binaryfate, I haven't updated this code in a while - recent version of my code (which should be more compatible with actual Monero) is at https://github.com/ShenNoether/MiniNero - sometime in the near future, I will most likely replace the code here with that, however I'm quite busy with the Ring CT stuff, as well as some unrelated projects, so it might be a month or two (iirc the original MiniNero code was just for the purpose of seeing how the ring sigs worked, and I didn't bother with the basic stuff)

binaryFate commented 9 years ago

Yes, I had a look at your more recent version and it's indeed much cleaner. Very appreciated! I must say I miss the tests there though, many tests are in old version and not in new one. They're very useful in learning how to do stuff.

ghost commented 9 years ago

Sure, once I get the ringCT stuff finished, I can add those tests into the newer version.

On 11/27/2015 12:40 PM, binaryFate wrote:

Yes, I had a look at your more recent version and it's indeed much cleaner. Very appreciated! I must say I miss the tests there though, many tests are in old version and not in new one. They're very useful in learning how to do stuff.

— Reply to this email directly or view it on GitHub https://github.com/monero-project/mininero/issues/1#issuecomment-160194628.