monero-project / monero-gui

Monero: the secure, private, untraceable cryptocurrency
Other
1.68k stars 760 forks source link

i18n issue: languages are not flags #1092

Open pazos opened 6 years ago

pazos commented 6 years ago

Hi, first and foremost I would like to say thanks to everybody involved in monero. This seems like a great community to join 👍 So far I've installed monero on Ubuntu and I'm starting to read the documentation.

There is a "little" issue on the GUI that annoys me: languages are not flags!

I know there are a lot of countries which are tied to a language unspoken in the rest of the world, but is not the case for a bunch of languages (spanish, english or portuguese come to my mind).

So the whole folder flags just doesn't make sense for me and I rather prefer to following these practices for representing languages

Please, share your opinion

danrmiller commented 6 years ago

These same thoughts come into my mind every time I see a PR about what flag to use for a translation.

erciccione commented 6 years ago

I agree we could use a better way to show languages, but i think can be tricky. If we leave only the languages (with no flags) is going to be extremely ugly and confusing. We might use something as described at the end of this article. "users are able to select from a variety of supported languages that are found in their chosen country."

pazos commented 6 years ago

@erciccione: In the example you linked that makes senses because LandRover.com provides different services for different countries. The same form is used to lookup for localization and language. AFAIK monero-gui has no plans to provide such localization based services.

In the context of a web page this could work for services like "where to buy", but forcing users to choose their country to then be able to select their language doesn't seems a good point for me in a project like monero

erciccione commented 6 years ago

Yes it's not optimal, but if we agree that a text only page would be ugly and confusing, i honestly don't see any other viable option for the GUI. Do you have any practical suggestion to improve the present way languages ar shown?

pazos commented 6 years ago

Just a quick draft of my suggestion :)

Original:

monero-welcome-current

New:

monero-welcome-new

An optional "Please select your language" between the globe icon and the language selector could be added.

erciccione commented 6 years ago

I'm not sure about the "welcome" part, since somebody may rise the issue of why some languages are chosen for the welcome message and other are not, but i like it! In case, would you be able to implement it yourself?

pazos commented 6 years ago

of course, the welcome part should have all languages supported :)

I'm new in QML, but I used pyqt a few times. I'll check the sources and ask for help if I need it.

Give me a few weeks

PD: "World Flags Globe" image is from wiki-commons. Are we ok with it?

erciccione commented 6 years ago

Perfect, thank you! Yes sure, no problem for the image If you need help you can find it here, on #monero-gui or #monero-dev on Freenode

sanderfoobar commented 6 years ago

+proposal

sanderfoobar commented 6 years ago

pinging @GBKS

GBKS commented 6 years ago

Languages are definitely not flags, but they do add a nice visual elements to the page. If you'd like to avoid it, maybe go for a simple list so people can quickly click through and get to the wallet. This is a very straightforward screen, so my approach would be to keep it simple, like the attached image. Just my 2 cents.

onboarding - choose language 2x

pazos commented 6 years ago

awesome KISS design @GBKS. I like it! @skftn, @erciccione what do you think?

erciccione commented 6 years ago

I like it. Simple and clean. Let's just keep in mind the available languages will be 29 not 9, so the format should be a minimum flexible.