search

monero-project / monero-gui

Monero: the secure, private, untraceable cryptocurrency
Other
1.74k stars 769 forks source link

Wallet options not clear anymore since hardware wallets were introduced #2324

Open ghost opened 5 years ago

ghost commented 5 years ago

[Updated!]

Quick & dirty proposal: image

Good proposal: image This would be in accordance to #2328, which doesn't create the impression that there's a difference between creating and restoring a wallet from hardware.

selsta commented 5 years ago

4 times “Choose this option”, is this an improvement?

ghost commented 5 years ago

Thank's for your feedback!! Updated!

selsta commented 5 years ago

I’m not happy with the 3rd one.

“Choose this option if you have used Monero before”, can be confusing. You can have used Monero on a different computer before.

What about: “Choose this option to open an existing Monero wallet from your computer.” ?

ghost commented 5 years ago

Your argument is good! What about leaving "from your computer", though? (Could be from USB-stick as well) --> "Choose this option to open an existing Monero wallet." ?

selsta commented 5 years ago

Ok. I’ll wait on other opinions before I implement it though.

ghost commented 5 years ago

Sure! Updated.

rating89us commented 5 years ago

Some considerations:

So, I believe there should be a clear separation: do you want to use a Monero wallet with a hardware wallet or not?

Use a Monero wallet without a hardware wallet:

Use a Monero wallet with a hardware wallet:

Some users might want to recover using Trezor/Ledger mnemonic seed, but this is not possible in Monero GUI. So Create/restore a wallet from hardware wallet page should inform that first they have to recover their Trezor/Ledger with mnemonic seed, and then use this page to restore their wallet from device.

@cslashm and @ph4r05 : Imagine I lost my device (Ledger/Trezor) after creating a Monero wallet file (.keys) from it. I then buy a new device and recover my device with my previous mnemonic seed. Will the old Monero wallet file (.keys file) work with this new hardware wallet device (recovered from previous mnemonic seed)? Or user must create a new wallet file for each new device?

ghost commented 5 years ago

I like your clear distinction between with/without hardware wallet! Very logical. But as always, it's a trade-off how much text we're willing to accept. So I guess the optimal solution depends on how popular hardware wallets are. Any estimates? 10% of our users? 90% of our users?

rating89us commented 5 years ago

We could either put everything on current page, or we could break all these options into two pages (with and without hardware wallet) and add an extra page to select if you want to use a hardware wallet or not.

image

ghost commented 5 years ago

Your proposal to make it 2 different pages (plus a 3rd page before) is very logical but not necessary with regard to the reasons you gave. I will go through them:

"Create a new wallet" is intended only for users that don't want to use a hardware wallet.

True, but the option for hardware wallets is directly below. That's super clear.

"Open a wallet from file" can be used both for users that have and don't have hardware wallets

True! I just added that info (see update) Thanks.

"Restore wallet from keys or mnemonic seed" can only be used for Monero wallets that don't support hardware. Ledger/Trezor users can't type device seed in this page. Also, hardware wallets don't inform their private keys to users.

True, I just added "or restore" to row 2 (see update) Thanks. (And by the way: The GUI never intended to directly support seeds from hardware wallets. That would break the point of hardware wallets if you entered the seed directly into your computer.)

ghost commented 5 years ago

Alternative proposal added. Thanks @rating89us for input.

rating89us commented 5 years ago

Hardware wallet icon should include both Ledger and Trezor (Model T). image

ghost commented 5 years ago

That would look like this: image

ph4r05 commented 5 years ago

@cslashm and @ph4r05 : Imagine I lost my device (Ledger/Trezor) + my Monero wallet file (.keys) that was created from my device. I then buy a new device and recover my device with my previous mnemonic seed. Will the old Monero wallet file (.keys file) work with this new hardware wallet device (recovered from previous mnemonic seed)? Or user must create a new wallet file for each new device?

When you recover device from the mnemonic seed, the existing wallet files will keep working. Trezor holds no state related to the Monero wallet (besides the seed) thus different devices with the same seed can be used interchangeably.

cslashm commented 5 years ago

@cslashm and @ph4r05 : Imagine I lost my device (Ledger/Trezor) after creating a Monero wallet file (.keys) from it. I then buy a new device and recover my device with my previous mnemonic seed. Will the old Monero wallet file (.keys file) work with this new hardware wallet device (recovered from previous mnemonic seed)? Or user must create a new wallet file for each new device?

Yes it will. Also note that Ledger provide tools to convert your 24 words of your NanoS/X into ELectrum 25 words usable to restore your wallet as a full software wallet (without HW)

rating89us commented 4 years ago

I don't like the added visual complexity.

So let's remove all hardware wallet icons. There is no reason to only have Ledger icon.

Supported hardware wallet models have been added in #2694.