search

monero-project / monero-gui

Monero: the secure, private, untraceable cryptocurrency
Other
1.75k stars 771 forks source link

[feature] Accounts tab: view address on hardware wallet #3506

Open jonathancross opened 3 years ago

jonathancross commented 3 years ago

It would be great if the user had a small eyeball icon on each address / subaddress allowing them to view the address on their hardware wallet.

The "View on hardware wallet" option would not be there for non-hardware wallets.

rating89us commented 3 years ago

This is already supported on Trezor, but on Receive page (#2221). Maybe you're refering to Ledger?

Also, I think that Account page shouldn't display any receiving address (#3128).

jonathancross commented 3 years ago

supported on Trezor, but on Receive page

Also supported by the Ledger Nano X as well on the Receive page.

I was referring to this feature being available for both hardware wallets on the Accounts tab/page (next to "copy to clipboard").

But I now see we are going in different directions as you believe addresses and "copy to clipboard" should be removed from that page entirely. Personally I am not a fan of having to go to the Receive page for all of these functions.

rating89us commented 3 years ago

I'm not against displaying an address on Accounts page, but IMO it should display an unused address every time the page is opened, to avoid address reusing.