search

monero-project / monero-gui

Monero: the secure, private, untraceable cryptocurrency
Other
1.74k stars 769 forks source link

Warn When Adjusting KDF Rounds #4076

Open russoj88 opened 1 year ago

russoj88 commented 1 year ago

After creating a wallet, if the number of KDF rounds is changed, the wallet password becomes invalid.

If this is the expected behavior, I think there should be a warning when changing it. A tooltip when the password is invalid may help too.

Originally from Reddit: https://www.reddit.com/r/monerosupport/comments/z7mjh5/comment/iyb9b50/?utm_source=share&utm_medium=web2x&context=3

selsta commented 1 year ago

Adjusting KDF Rounds Invalidates Current Password

That's intended behaviour.

Maybe you can change the issue title to something like "warn when adjusting KDF Rounds"

russoj88 commented 1 year ago

Done.

Does it make sense to set the KDF rounds per seed instead of GUI-wide?

selsta commented 1 year ago

Does not work unfortunately, to save something inside the wallet cache you first have to decrypt it, which requires the amount of KDF rounds.