search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
288 stars 391 forks source link

Links don't open in new tabs #1921

Open konstantinosfragkoulis opened 2 years ago

konstantinosfragkoulis commented 2 years ago

On the website there are many links which have next to them the symbol that indicates that they will open in a new tab but they don't Screenshot from 2022-01-28 10-13-18 .

erciccione commented 2 years ago

The symbol is to warn the user that they are about to click on an external link. Meaning they will leave getmonero for an external website, it's not meant to signal that a new tab will be open.

Either way, i'm ok with #1922, which makes external links open in a new tab.

FedericoNembrini commented 1 year ago

I saw that pull request #1922 has been closed, maybe I can take care of that.

From what I've read, target="_blank" should be added to all <a /> that lead to sites other than this one (or rather, those to which this style a[href^="https:"]:not([href*="getmonero.org"]) is applied).

The resource files in the _i18n/ directory shouldn't be modified, right?

erciccione commented 1 year ago

@FedericoNembrini that would be appreciated, thanks :)

The resource files in the _i18n/ directory shouldn't be modified, right?

Only the english files should be edited (en folder and en.yml)