monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

Moneropedia address article clarification #1947

Closed FemboyJS closed 2 years ago

FemboyJS commented 2 years ago

In the Moneropedia address article it says raw addresses start with a 4, and then it seemingly gives the monero donation address as an example, which does not start with a 4. Could this do with some clarification?

moneroguides commented 2 years ago

yea, that's pretty poor. the example should definitely follow the definition.

Mark-777-0 commented 2 years ago

Ill send a pull request with some fixed info, as some exchange addresses for monero can start with 8 as well, (Binance, KuCoin, Bitfinex...). So raw addresses can start with 4 or 8 it seems.

I'm new to open source how would I go about helping? I'll make an edit suggestion and try. let me know

Mark-777-0 commented 2 years ago

1990

Mark-777-0 commented 2 years ago

Not sure how to link my pull request here, sorry I'm very new @moneroguides @alphatomcat @erciccione .

Let me know if I broke any etiquette, and how to do better next time 👍

Mark-777-0 commented 2 years ago

I can update the other languages if it's not a bad edit

Mark-777-0 commented 2 years ago

@erciccione would you like me to do the other languages as well now?

erciccione commented 2 years ago

@Mark-777-0 language files shouldn't be edited on the repository or we risk conflicts on Weblate. The PR will do it fine :)