search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

Fix a small typo, a wording, and a hyperlink #1985

Open LeoNero opened 2 years ago

LeoNero commented 2 years ago

This PR fixes a small typo, a wording, and a hyperlink

Also, it fixes the "the announcement post." on the "P2Pool: The best of both solo and pool mining" at https://www.getmonero.org/get-started/mining/, which currently redirects to https://www.getmonero.org/get-started/mining/%7B%7B%20site.baseurl%20%7D%7D/2021/10/05/p2pool-released.html

netlify[bot] commented 2 years ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit 0342af375fa9c20bf5b73efb1f134298b4891232
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/62a8083b167976000856ed69
Deploy Preview https://deploy-preview-1985--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netrik182 commented 2 years ago

I think we already have such split keys i.e. https://github.com/monero-project/monero-site/blob/abcf12c4ccac3e48bb4ff178f18bb8a95d94b029/_i18n/en.yml#L334

apertamono commented 2 years ago

For the record, the broken link has been fixed in #1959, without splitting the string.

@netrik182:

I think we already have such split keys

We started using such split keys before translations were done one string at a time in Weblate. Translators had more context, since they edited the whole file. So that's not a good precedent.

@selsta Thanks for considering translation issues. Possible translation issues include:

I've worked with a commercial version of Weblate which automatically put all hyperlink code in a placeholder, which would avoid any accidental changes, but on the other hand: