monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

remove / update broken links from tools page #1987

Closed HardenedSteel closed 2 years ago

HardenedSteel commented 2 years ago

closes #1980

netlify[bot] commented 2 years ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit a7a0dc14cfcd7be16618a156e95e5976f02c39d5
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/62d705e586b5210009fa6a33
Deploy Preview https://deploy-preview-1987--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

plowsof commented 2 years ago

Nice, so my understanding is that these are broken / and removed in this PR:

Looks great, im just wondering what these checks are complaining about.. translation files? if some manual labour / file parsing is needed i could cobble a script together to help

netrik182 commented 2 years ago

I don't think it's broken because of translations.

plowsof commented 2 years ago

The checks seem to have been 'cancelled', assuming an unrelated error? but from here, everything looks good, i approve. i suppose the commit message could be changed to be less ambiguous e.g. "remove / update broken links from tools page"

HardenedSteel commented 2 years ago

The checks seem to have been 'cancelled', assuming an unrelated error? but from here, everything looks good, i approve. i suppose the commit message could be changed to be less ambiguous e.g. "remove / update broken links from tools page"

updated pull request title but i don't think i can change commit message anymore.

HardenedSteel commented 2 years ago

I couldn't do it I will create another PR