search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
287 stars 391 forks source link

correct global variable "outdated" text #2055

Closed jorgesumle closed 1 year ago

jorgesumle commented 2 years ago

I didn't understand the sentence while translating, so I thought there was a mistake. Is this what you mean?

netlify[bot] commented 2 years ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit 2537f3477881d7f5c602fd7791fbd752204b9e9f
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/63442e221d083c00092ea50d
Deploy Preview https://deploy-preview-2055--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

plowsof commented 2 years ago

Thanks good spot. This commit should only be "the" -> "it" and contains unnecessary diffs because of white space editing

we could even delete "the" all together and have "this page is outdated and might not be valid anymore."

The commit title "Correct text" needs to be changed to something more useful like 'correct global variable "outdated" text', and you are using your master branch. this is not recommended and i made the same mistake with my first PR. you need to reset your master branch. close this PR, create a new branch, make the small correction and resubmit.

jorgesumle commented 2 years ago

I think the trailing whitespaces are problematic. See this string from Weblate, it has two spaces between words instead of one:

double-space

configuration and  tips network  in