search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
288 stars 391 forks source link

Add Stack Wallet to Downloads page #2081

Closed rehrar closed 4 months ago

rehrar commented 2 years ago
netlify[bot] commented 2 years ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit 5d0544a79588de82bc96924594c9c8e7449f87b2
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/634f29a88142c9000927cdaa
Deploy Preview https://deploy-preview-2081--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rehrar commented 2 years ago

Don't merge yet plz. A few bugs (in the wallet, not the PR) to iron out before "going live", but will notify when it's ready to go.

erciccione commented 2 years ago

Leaving my personal opinion aside, I don't think we ever listed a wallet that hasn't been around for quite some time, has been tested extensively and considered trusted/secure enough by the community. This wallet hasn't even been launched yet. I think this pr is very premature.

erciccione commented 1 year ago

There was no further communication so i'm assuming the wallet is still in testing. Feel free to reopen this PR when you think it's ready to be added to getmonero, so that the pr can be discussed and reviewed.

plowsof commented 9 months ago

any progress with those bugz / willingness to go live? @rehrar

rehrar commented 4 months ago

Yes, we're ready to be added now @plowsof

nahuhh commented 4 months ago

Yes, we're ready to be added now @plowsof

Need to reopen the PR :P

plowsof commented 4 months ago

Czarek of XMRUW recently completed milestone 1 of his ccs proposal. It's my understanding that StackWallet benefited directly/indirectly from this and is now running a new/updated wallet library which comes with (among other things) a lot of stability fixes. Regular updates have been pushed out since this issue was made (over 1 year ago) and it seems stackwallet is here to stay ACK from me.

something to consider: the first release (not marked as beta or pre-release was June 14th) v2.1.0. how do we interprate this @rehrar? that the wallet is new and scary? or battle tested and finally 'ready?