monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
288 stars 391 forks source link

'openalias_address' is a string, not a bool in doc #2097

Closed ryn0 closed 1 year ago

ryn0 commented 2 years ago

When getting a response back for validating an address with the RPC client, the result for 'openalias_address' is a string, not a boolean.

netlify[bot] commented 2 years ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit 09c428b9c505d41621ed6714ca62b64e62859d5e
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/6364676e06c66e000887a086
Deploy Preview https://deploy-preview-2097--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

plowsof commented 2 years ago

confirmed. Thanks, i will add this to #2083 and credit you (the order of the outputs is not important)

ryn0 commented 2 years ago

Thanks! I didn't think the order mattered but wanted to have the exact response I was getting in the doc.

plowsof commented 2 years ago

could we say something slightly different like? (i'll sneak in some quotes around "params" too, don't tell anyone)

here is the commit to the docs PR: https://github.com/monero-project/monero-site/pull/2083/commits/443b31b051ed89bf72aee545e0fe9be6ea3acf11

ryn0 commented 2 years ago

Added another commit with those changes.

plowsof commented 1 year ago

closed by #2083 (added as a commit there) thanks ryn0, this can be closed now.