search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
288 stars 391 forks source link

Set anchors target for external urls to _blank #2118

Closed FedericoNembrini closed 1 month ago

FedericoNembrini commented 1 year ago

As discussed in #1921 and #1922, I set the target to _blank for links to external sites.

I have only modified links that comply with the css rule applied via a[href^="https:"]:not([href*="getmonero.org"]) and which therefore display the external.svg icon

netlify[bot] commented 1 year ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit d01a074d1d7f1ccf28dc650ea157af23704ee966
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/6487735ab1cfdc0008ba0d4f
Deploy Preview https://deploy-preview-2118--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

plowsof commented 1 year ago

If @erciccione could clarify the scope of this PR (en folders are mentioned here) i can review/help if needed.

erciccione commented 1 year ago

If @erciccione could clarify the scope of this PR (en folders are mentioned https://github.com/monero-project/monero-site/issues/1921#issuecomment-1365810169) i can review/help if needed.

The en folders don't need to be touched in this case as most if not all links are inside the documents themselves.

erciccione commented 1 year ago

closes #1921

erciccione commented 1 year ago

@FedericoNembrini there are some conflicts that need to be solved before we can merge this.

FedericoNembrini commented 1 year ago

I have resolved the merge conflicts, have I forgotten something?

erciccione commented 1 year ago

@FedericoNembrini The last commit you pushed is a merge commit. That usually happens after a borked rebase. You could try to remove it and rebase again, fixing the merge conflict.

FedericoNembrini commented 1 year ago

I have resolved conflicts with github built in function. I'll try to remove my last commit and do a rebase.

erciccione commented 1 year ago

@FedericoNembrini please fix the conflicts and rebase :)

erciccione commented 1 year ago

ping @FedericoNembrini

FedericoNembrini commented 1 year ago

I will fix this in the coming days

plowsof commented 9 months ago

there is a plugin which claims to do this automagically for external links. i have not tested it yet but looks promising https://github.com/keithmifsud/jekyll-target-blank