monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

bug when displaying tags on blog posts #2124

Closed erciccione closed 1 year ago

erciccione commented 1 year ago

Screenshot_20230202_100231 (from https://www.getmonero.org/2023/02/02/seraphis-jamtis-developer-opportunities.html)

There is some problem while looping through the tags of a post. I might have an idea of why, as it could be related to the trimming of blog post tags done some years ago.

plowsof commented 1 year ago

I should have noticed this in review, i vaguely remember glancing at those tags and assuming it was a problem on my end and then focused on the content of the blog post. After investigating, it is just a simple case of 'forgetting to add the tags'. the reason for the duplication is:

For every tag in tags.yml, if the slug == "Community" then append the tag. https://github.com/monero-project/monero-site/blob/2efb6619b9883767d5a4acd3de21b507a53daba3/_layouts/post.html#L10

Because the other tags do not exist to change the variable, "Community" just gets appended each time (the correct number of times for how many tags there are). so nothing nefarious is happening here, just a slip up. #2125