add self-hosted wallet generator

erciccione commented 1 year ago

This is @moneromooo-monero's wallet generator (https://github.com/moneromooo-monero/monero-wallet-generator) adapted for getmonero. It will be available at getmonero.org/generator.

Changes:

changed structure to make it more mobile friendly
removed some unused css
added getmonero's headers for SEO and opengraph views

I touched the file as less possible to make reviewing easier. It could be cleaned up further. I stopped when realized there is too much stuff entangled with each other (printable page, mobile, etc) and would take too long. Probably not worth it.

The file assumes there is a signed version of the page hosted in the same folder and signed with @binaryFate's key.

closes #2121

netlify[bot] commented 1 year ago

Deploy Preview for barolo-time-757cf9 ready!

Name	Link
Latest commit	ae4c04de53ad8234517bb5bb9dafdf8da01f283a
Latest deploy log	https://app.netlify.com/sites/barolo-time-757cf9/deploys/645758890625d500083cf938
Deploy Preview	https://deploy-preview-2131--barolo-time-757cf9.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

erciccione commented 1 year ago

Added fixes suggested by ofrnxmr and added dummy signed page and dummy zip file

erciccione commented 1 year ago

CI fixed by #2135

plowsof commented 1 year ago

tried to comment a suggestion for credits, didn't go well so ill just add it here: no one has a 2nd handle, and improves clarity as to what updates where done

orig:

Made by moneromooo. Original CSS by antanst, crypto fixes by luigi111. Based on code from <a href="https://mymonero.com/" target="_blank">MyMonero</a>. Updated and adapted for Getmonero.org by ErC (ErCiccione). Copyright notices in the source.

suggestion:

Made by moneromooo. Original CSS by antanst (Updated and adapted for Getmonero.org by ErCiccone), crypto fixes by luigi111. Based on code from <a href="https://mymonero.com/" target="_blank">MyMonero</a>. Copyright notices in the source.

and i just want to clear that removing mooos donation address was agreed on? i understand there are reasons for this e.g. security

erciccione commented 1 year ago

and i just want to clear that removing mooos donation address was agreed on? i understand there are reasons for this e.g. security

@plowsof I removed it and pointed people to his version, which includes the donation address. I didn't think it made sense to add the address on getmonero's version and we would also always need to make sure the address is still used.

erciccione commented 1 year ago

Since multiple people requested it and luigi is ok with the extra commit, i added a commit with moneromooo's original file and added my changes on top of it to show the diff. The original signature is also included. Please review.

erciccione commented 1 year ago

Force pushed to use ErCiccione instead of ErC (ErCiccione) in the credits, as suggested by selsta.

erciccione commented 1 year ago

Added suggestions from @hinto-janai. Let's wait some days for more reviewers. After we need to get the file signed by @binaryFate or somebody else from core.

erciccione commented 1 year ago

Added @hinto-janai's suggestions. I would say it's ready to be signed by @binaryFate.

rbrunner7 commented 11 months ago

Does this wait for a second review? Or is it controversial in any way? Or simply fell through the cracks?

I recently wanted to send somebody asking for a paper wallet generator on Reddit to our page on getmonero.org about that and was quite puzzled to still see https://moneroaddress.org/ there ...

plowsof commented 11 months ago

How to review/sign/zip files:

Step 1: now that this PR is merged into master, perform interactive rebase (rename pick to edit on original wallet generator from moneromooo and save)
```
git rebase -i d9dcbd0~
edit d9dcbd08 original wallet generator from moneromooo
```

Step 2: cd to wallet-generator folder / Download and import mooos public key

cd resources/wallet-generator/
wget https://raw.githubusercontent.com/monero-project/monero/master/utils/gpg_keys/moneromooo.asc
gpg --import moneromooo.asc && rm moneromooo.asc

Step 3: Verify the signed file

gpg --verify monero-wallet-generator.html.asc

Step 4: Finish the rebase
```
rebase --continue
```

Setp 5: Rename files for the following steps

rm monero-wallet-generator.placeholder.zip && mv monero-wallet-generator.html wallet-generator.html && mv monero-wallet-generator.html.asc wallet-generator.html.asc

Step 6: Sign the HTML file with your own key (Overwrite existing file)

gpg --output wallet-generator.html.asc --armor --detach-sig wallet-generator.html

Step 7: Create a ZIP file

zip wallet-generator.zip wallet-generator.html wallet-generator.html.asc

Double check the file/folder structure:

resources/
└── wallet-generator/
  ├── index.html
  ├── wallet-generator.html
  ├── wallet-generator.html.asc
  └── wallet-generator.zip
      ├── wallet-generator.html
      └── wallet-generator.html.asc

Step 9: Write a cool commit message
```
commit -m "wallet-generator: signed and zipped by username"
```
i also sign it after verifying the diffs touch nothing sensitive

erciccione commented 11 months ago

Does this wait for a second review? Or is it controversial in any way? Or simply fell through the cracks?

This is only waiting for @binaryFate's signature. it's ready to be merged.

@plowsof About renaming files. This is not only a Monero wallet generator, it also works with other currencies.

About changing online-offline. it's a very minor edit, but that would cause people to re-review the entire commit, which was already hard to get reviewed, given the complexity and sensitivity of the file. Better not touch this commit now that has been thoroughly reviewed and open successive prs for minor edits.

plowsof commented 11 months ago

@erciccione ignore the online/offline html snippet (that was just for renaming files), the generator is fine now, i will update my steps to reflect the renaming of files and approve, thanks.

rbrunner7 commented 8 months ago

Still not merged? Paging @binaryFate

It's getting embarrassing that almost a full year after we "lost" moneroaddress . org to a squatter we still send people there.

monero-project / monero-site