plowsof commented 1 year ago

Acting as a review for #2131

todo: some tweaks / bolded text here and there - possible adjustments to usage ( more details or just little but link the getmonero guide)

steps 1-3 to help reviewers confirm the original is mooos (and 4-5 is what bF must do after approval):

2139 adds a workflow check to confirm both the html and zipped version are signed)

Step 1: after puling this PR, Perform interactive rebase (rename pick to edit wallet-generator: add mooos original version)
```
git rebase -i 85c43dd^
```

Step 2: Download and import mooos public key

wget https://raw.githubusercontent.com/monero-project/monero/master/utils/gpg_keys/moneromooo.asc
gpg --import moneromooo.asc

Step 3: Verify the signed file

cd resources/wallet-generator/
gpg --verify monero-wallet-generator.html.asc
git rebase --continue

Step 4: Sign the HTML file with your own key (Overwrite existing file)

gpg --output monero-wallet-generator.html.asc --armor --detach-sig monero-wallet-generator.html

Step 5: Create a ZIP file

zip monero-wallet-generator.zip monero-wallet-generator.html monero-wallet-generator.html.asc

resources/
└── wallet-generator/
├── monero-wallet-generator.html
├── monero-wallet-generator.html.asc
└── monero-wallet-generator.zip

netlify[bot] commented 1 year ago

Name	Link
Latest commit	dee5b5a6af8e51ece34928fee8c2e2e37b60e644
Latest deploy log	https://app.netlify.com/sites/barolo-time-757cf9/deploys/644286ebef51b90008f0d4c9
Deploy Preview	https://deploy-preview-2156--barolo-time-757cf9.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

plowsof commented 1 year ago

closing after most of suggestions have been applied to the original and it has obtained an approval

monero-project / monero-site