monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
287 stars 391 forks source link

Fix currency amount formatting #2163

Open getsnoopy opened 1 year ago

getsnoopy commented 1 year ago

It seems like throughout the website (and the videos), currency amounts are formatted with the quantity first and the currency code following it (e.g., 5 XMR), which is incorrect. In English, all currency amounts are formatted with currency symbols and codes which precede the quantity, with symbols being unspaced (e.g., $5, US$5) and codes being spaced (e.g., USD 5). Seeing as the homepage itself says "It's a Currency: Use It!", this should be fixed so that it's consistent with all other currencies.

erciccione commented 1 year ago

Usually, the currency symbol user for Monero (ɱ) is used the ways you suggest (e.g. ɱ1.5). Considering that English is the only major language using code first and sum after, while all the other major latin languages put the amount first and the code after (so we would need to use a structure for english and a different structure for all other languages), i would just stick with the current structure, which is also the most commonly used.

getsnoopy commented 1 year ago

Well it is incorrect in English, so it should be fixed (in the same way Arabic is the only major RTL language in the languages we support, but we wouldn't be using LTR for it just because every other language doesn't use it). There wouldn't need to be a different "structure" at all; we could just have an i18n entry that provides the correct formatted currency for the current language, which would have XMR %s or the like for English and other languages which use this format, and %s XMR for the rest.

erciccione commented 1 year ago

Even if not technically correct for the English language, N XMR is the most commonly used structure and immediately recognized by most, so we could keep it as it is. Even more so if we consider that the current structure is already correct for all languages except English. If this is considered an issue worth working on, PRs are welcome.

plowsof commented 4 months ago

ive just assumed "N XMR" or "ɱXMR" is universal for all cryptocurrencies / hadn't given it much thought