search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

workflows: verify redirect urls in downloads.yml #2197

Closed plowsof closed 11 months ago

plowsof commented 11 months ago

re-download all binaries using their redirect urls and confirm hashes.

displays a warning if files downloaded using the redirect urls do not match the hashes in downloads.yml

if there is a mis-match / or the redirects are not updated to point at the new files yet, the workflow will still be green and only produce warnings. re-running the workflow manually after site is deployed / redirects pointing to new files will remove the warnings.

example run showing a warning: https://github.com/plowsof/monero-site/actions/runs/6487887488

on workflow_dispatch: can be added to make running the workflow manually (if needed)

netlify[bot] commented 11 months ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit 07a57956ce46db660f54e90e51ee2c27e562ff16
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/652715dd150ae80008c42a4b
Deploy Preview https://deploy-preview-2197--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

plowsof commented 11 months ago

The problem has been fixed. This workflow will prevent/detect the problem we had, however,

i think it's better suited to be run on a contributors repo , 'after the fact' to confirm things are ok, rather than here on -site.. im leaning to close

erciccione commented 11 months ago

i think it's better suited to be run on a contributors repo , 'after the fact' to confirm things are ok, rather than here on -site.. im leaning to close

Agree. Or a script on somebody's computer. No reason to add it on this repo.