monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
288 stars 391 forks source link

Add the Flathub verify token #2200

Open BigmenPixel0 opened 1 year ago

BigmenPixel0 commented 1 year ago

Add this token 0a1ae4b2-3a4b-4f2d-bcd7-c9ff261e0f05 into /.well-known/org.flathub.VerifiedApps.txt to verify the application on Flathub.

plowsof commented 1 year ago

Example: https://fedoraproject.org/.well-known/org.flathub.VerifiedApps.txt

This is for the Monero GUI Flatpak. We need the verified status to (in part) obtain a stable API key for this workflow which is using a beta key: https://github.com/monero-project/monero-gui/blob/master/.github/workflows/flatpak.yml

context: https://github.com/flathub/flathub/issues/3905#issuecomment-1591048976

bigmenpixels in-progress CCS proposal - Maintaining Flatpak package

erciccione commented 1 year ago

The best way to do this is probably through the web server. I'll ping pigeons.

erciccione commented 1 year ago

Maybe this should be discussed first. Verifying the flatpak from getmonero will mean that an effort completely run by a volunteer is "guaranteed" by the core team as trusted. Not sure if this should be the case, as nothing in the community is "official". Might be better to leave the flatpak "unverified". Asking for an input from core.

Victor239 commented 1 year ago

Agreed, only do this if you're given commit control over the repo and the current maintainer has to instead submit PRs for any changes so that core can review them for malicious changes first.

plowsof commented 1 year ago

Edit* the flatpak workflow is now being reviewed. i think we can re-discuss/hold off until thats complete

some discussion can be seen in this comment and others on the proposal: https://repo.getmonero.org/monero-project/ccs-proposals/-/merge_requests/381#note_21079

originally i agreed that its never going to be verified (as its clearly ripe for supply chain attacks - we don't control the flathub servers), however, i now support this "checkmark" for these reasons: