search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

devguides: add subtract_fee_from_outputs to wallet-rpc transfer #2249

Open plowsof opened 7 months ago

plowsof commented 7 months ago

blocked until next release

closes #2248

netlify[bot] commented 7 months ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit 3b4c5bf022cae223188bebfbfd32355e630cda5a
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/6686763e6c29a70008e42785
Deploy Preview https://deploy-preview-2249--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jeffro256 commented 4 months ago

The word "proportionally" here might be misleading. The feature splits the fee evenly between the destinations flatly, i.e. regardless of destination amount.

plowsof commented 4 months ago

Thanks @jeffro256, something like this: ?

The fee will be subtracted evenly from each destination (regardless of amount).

Thoughts on this warning or is it dumb

Do not use this if recipient requires an exact amount.

jeffro256 commented 3 months ago

No that would be a good warning to put IMO. Also latest commit looks good