monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

contributing index.md: add donate anchor #2287

Open plowsof opened 5 months ago

plowsof commented 5 months ago

the idea is to link the DONATE button/page @ https://ccs.getmonero.org/donate/ to instead link you to : (has translated strings.. working QR's for both Monero and Bitcoin) https://deploy-preview-2287--barolo-time-757cf9.netlify.app/get-started/contributing/#donate

netlify[bot] commented 5 months ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit b99c2474d053c63235a2f68cbe503028902ad15d
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/66222f936e3e51000821d8e5
Deploy Preview https://deploy-preview-2287--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nahuhh commented 2 months ago
  1. Unlike "getting started > contributing", the qr code on ccs.getmonero.org is clickable (has a proper monero:address uri) nwaiqzkagdi2a4xo.png

  2. The btc qr code on "getting started > contributing" is broken on dark theme browsers because it has a transparent border (needs to be white). j0fg2sth0fjha1lr.png

  3. The broken xmr qr code is at the bottom of every page on ccs.getmonero.org, not just https://ccs.getmonero.org/donate tmzm6vo4nu8g2gdi.png

imo, makes more sense to ust swap out the broken ccs.getmonero.org xmr qr code image with the working qr code from here https://deploy-preview-2287--barolo-time-757cf9.netlify.app/img/donate-monero.png donate-monero.png

And separately fix the btc qr code on "getting started"by removing transparency

plowsof commented 2 months ago

thanks for looking into this @nahuhh , i think my PR solves the broken ccs qr code @ https://repo.getmonero.org/monero-project/ccs-front/-/merge_requests/38

nahuhh commented 2 months ago

On gitlab, the png has 2 versions

left = broken + transparent(which also breaks it) right = correct

o1b3fkzoabqg36yq.png