search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

add note about `get_transfers`/`get_transfer_by_txid` `destinations` being undefined, make it more consistent #2306

Open recanman opened 3 months ago

netlify[bot] commented 3 months ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit 8929891f487f37ca4059ea73f7d357795c5e16e2
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/6690ca5e4064a20008101de7
Deploy Preview https://deploy-preview-2306--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

HardenedSteel commented 2 months ago

squash?

recanman commented 2 months ago

@HardenedSteel squashed

plowsof commented 2 months ago

would it not be better to just add a "Note: ..." next to the destinations* param? the scary warning for unlock time was an exception, unless this is of the same severity if overlooked?

jeffro256 commented 1 month ago

would it not be better to just add a "Note: ..." next to the destinations* param? the scary warning for unlock time was an exception, unless this is of the same severity if overlooked?

I think it's worthy of a warning, since you can permanently lose accounting information, which I remember caused at least one person financial damage since they couldn't provide a valid tx spend proof to their exchange.

plowsof commented 4 weeks ago

with the new docs site we can play around with warnings.

would it not be better to just add a "Note: ..." next to the destinations* param? the scary warning for unlock time was an exception, unless this is of the same severity if overlooked?

I think it's worthy of a warning, since you can permanently lose accounting information, which I remember caused at least one person financial damage since they couldn't provide a valid tx spend proof to their exchange.

the possible repercussions of deleting the wallet cache / re-syncing a wallet would fill the entire doc with red warnings. so i would NACK this PR as is. This would seem better fitting as a Note about working with wallets / monero-wallet-rpc. The new docs site can facilitate this better i feel.