add note about `get_transfers`/`get_transfer_by_txid` `destinations` being undefined, make it more consistent

netlify[bot] commented 5 months ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name	Link
Latest commit	8929891f487f37ca4059ea73f7d357795c5e16e2
Latest deploy log	https://app.netlify.com/sites/barolo-time-757cf9/deploys/6690ca5e4064a20008101de7
Deploy Preview	https://deploy-preview-2306--barolo-time-757cf9.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

HardenedSteel commented 4 months ago

squash?

recanman commented 4 months ago

@HardenedSteel squashed

plowsof commented 4 months ago

would it not be better to just add a "Note: ..." next to the destinations* param? the scary warning for unlock time was an exception, unless this is of the same severity if overlooked?

jeffro256 commented 3 months ago

would it not be better to just add a "Note: ..." next to the destinations* param? the scary warning for unlock time was an exception, unless this is of the same severity if overlooked?

I think it's worthy of a warning, since you can permanently lose accounting information, which I remember caused at least one person financial damage since they couldn't provide a valid tx spend proof to their exchange.

plowsof commented 2 months ago

with the new docs site we can play around with warnings.

would it not be better to just add a "Note: ..." next to the destinations* param? the scary warning for unlock time was an exception, unless this is of the same severity if overlooked?

I think it's worthy of a warning, since you can permanently lose accounting information, which I remember caused at least one person financial damage since they couldn't provide a valid tx spend proof to their exchange.

the possible repercussions of deleting the wallet cache / re-syncing a wallet would fill the entire doc with red warnings. so i would NACK this PR as is. This would seem better fitting as a Note about working with wallets / monero-wallet-rpc. The new docs site can facilitate this better i feel.

example of notes at the top https://2.test.monerodevs.org/interacting/monero-wallet-rpc-reference/
different style of a note e.g. warning example @ https://2.test.monerodevs.org/interacting/monero-wallet-rpc-reference/#describe_transfer
they can be collapsible also

plowsof commented 1 month ago

docs are moving to https://github.com/monero-project/monero-docs

merged in https://github.com/monero-project/monero-docs/pull/67

closing. thank you

monero-project / monero-site