Closed plowsof closed 2 months ago
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | dcdee73998bb02b1d0f9c8e1c908a1abb62841e0 |
Latest deploy log | https://app.netlify.com/sites/barolo-time-757cf9/deploys/66928888e2706800084be435 |
Deploy Preview | https://deploy-preview-2314--barolo-time-757cf9.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
appears to be fine: https://discord.gg/SyGUMWBqvF (just not working for me as ive not verified my discord account)
https://discord.com/invite/SyGUMWBqvF
does this one work?
can we just split the icons? which would be easier to work in future
can we just split the icons? which would be easier to work in future
We were already using a (broken) sprite sheet. This PR has 2 commits.
IMO, if we want to change the sprite to individual icons, that is a new PR
sprites have pros/cons. reducing network requests to getmonero by allowing clients to used the cached image seems beneficial enough to just fix/set and forget as we don't work with them often/ever. a PR adding new separate icons would only be warranted if it came with a redesign or quality increase without any increase in network load to the server using fancy new tech (im not qualified enough to produce such a PR of course)
*theres a plugin for that^ works great.
ignore my above comment about lazy-loading, since 2020 its a default in most/all browsers. the fact that we have a sprite image on our website is embarrassing. we have separate icon files for other things so this is just a relic of the past and needs to be deprecated / replaced with separate, updated icons (which involves design work + style edits to display correctly), but, as @nahuhh mentions above, this PR is fixing the current broken icons/coordinates and pulling in a new discord icon + reducing the original sprite image size by 29% after the work was already done and reviewed so i support this merge. from this point on, no more edits to sprites!
also:
- Maintainers SHALL merge correct patches from other Contributors rapidly.
- Any Contributor who has value judgments on a correct patch SHOULD express these via their own patches.
replaces / includes #2307 *Add discord to hangouts
opening the spritesheet in GIMP to obtain pixel correct values:
all issues fixed in this PR:
so we now have 43+5 actual spacing to avoid confusing the next generation