Open plowsof opened 3 months ago
plowsof
commented
3 months ago i seem to have got it working, just the .rb file in _plugins will auto load. combined with cleaning any mention of JML plugin from config files https://jekyllrb.com/docs/plugins/installation/
plowsof
commented
3 months ago ruby 3.2.4 now builds with a custom JML script. the "nil into string" error was fixed by adding some extra parsing logic. this was a speedrun just to make myself feel confident about getmonero having a none EOL ruby version in ~8 months. I need to put the changes into an acceptable/re-viewable PR.
prefacing this by saying i don't know what ruby or gems are.
please read 2140 for more context:
2140
we are currently forced to use ruby < 3.2.0 which is not good for long term as Ruby EOL's versions frequently
Jekyll multiple language (JML) plugin has an "
exists?" which can be simply fixed, just like in this upstream PR but its not maintained anymore.we also have an "
exists?" to be replaced with "exist?" here https://github.com/monero-project/monero-site/blob/99fd539bea6b819ce1a3a02722d3062cf6f18fc6/_plugins/sitemap_generator.rb#L129we're using JML version 1.7.0 but there is a 1.8.0 version that has an error reg parsing a nul string, which is either another dependency issue (paginate) or fixable if we can modify JML ourselves: no implicit conversion of nil into String since 1.8.0
Now to my request. So before i can even attempt to fix the lowest hanging fruit "exists?" -> "exist?" issue, i need to use/import a custom version of JML.
Jekyll multiple languages plugin describes how to import/use the plugin manually (or as a submodule): https://github.com/kurtsson/jekyll-multiple-languages-plugin?tab=readme-ov-file#32-manually
I couldn't get it to work.. infinite recursion.. dependency still attempted to be grabbed from an external resource instead of locally. I am hoping its just my lack of ruby/gem/plugin knowledge and someone can help/advise.