Closed HardenedSteel closed 1 month ago
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | 3327e4fa466088f94839904ebbd2ecd740bca7c1 |
Latest deploy log | https://app.netlify.com/sites/barolo-time-757cf9/deploys/6709e8bef4fef50008bd920b |
Deploy Preview | https://deploy-preview-2364--barolo-time-757cf9.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
its nice to see inline srcset however what are we doing here? future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly? if we had translations set up we would be presenting translators with alot of raw html. replacing the screenshots with new avifs is perfectly acceptable.
I'd much rather see your efforts and knowledge put into how we should be displaying images in astro / discussing fallbacks/image types with the new designer/dev.
future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly?
yes, JPEG XL has more features and looks more freer format*, that's why I preferred over AVIF.
In my testings: AVIF performing better for more lossy pictures JPEG XL performing better for less (or lossless) pictures
there's more detailed comparison: https://cloudinary.com/blog/time_for_next_gen_codecs_to_dethrone_jpeg
converting to ready for review, IOS screenshots can be fixed with different PR
NACK - remove the srcset busy work.
Apparently iOS screenshots look the same as Android's so @HardenedSteel is suggesting we skip those and just use Android's.
Related link.
IOS screenshots are missingIOS and Android GUIs are same so IOS screenshots are removed and not updated.will close #2361