search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
275 stars 384 forks source link

update userguide matrix via element #2364

Open HardenedSteel opened 1 month ago

HardenedSteel commented 1 month ago

IOS screenshots are missing

will close #2361

netlify[bot] commented 1 month ago

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
Latest commit e7d9957a2486fedfca01e5e0bffa5f1e95ee8df4
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/66d4ec20f9a35d0008ff1fd9
Deploy Preview https://deploy-preview-2364--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

plowsof commented 1 month ago

its nice to see inline srcset however what are we doing here? future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly? if we had translations set up we would be presenting translators with alot of raw html. replacing the screenshots with new avifs is perfectly acceptable.

I'd much rather see your efforts and knowledge put into how we should be displaying images in astro / discussing fallbacks/image types with the new designer/dev.

HardenedSteel commented 1 month ago

future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly?

yes, JPEG XL has more features and looks more freer format*, that's why I preferred over AVIF.

In my testings: AVIF performing better for more lossy pictures JPEG XL performing better for less (or lossless) pictures

there's more detailed comparison: https://cloudinary.com/blog/time_for_next_gen_codecs_to_dethrone_jpeg

HardenedSteel commented 2 weeks ago

converting to ready for review, IOS screenshots can be fixed with different PR

plowsof commented 2 weeks ago

NACK - remove the srcset busy work.