search

monero-project / monero

Monero: the secure, private, untraceable cryptocurrency
https://getmonero.org
Other
8.99k stars 3.11k forks source link

Wrong SKEIN function selection for cryptonight implementation #2001

Closed remagpie closed 7 years ago

remagpie commented 7 years ago

According to this document, hash function should select SKEIN-256 at certain situation. However, according to crypto/skein.c, SKEIN-256 is turned off. Instead, SKEIN-512 with block size 256 is turned on. Is there any specific reason for this?

fluffypony commented 7 years ago

@Kais-DkM I wouldn't trust documents on the CryptoNote website, as they were created after-the-fact. With inherited code like this we veer more towards "the documentation is the code", and tend not to change things unless they have been found dodgy in practice or there is some suspicion of brokenness.

remagpie commented 7 years ago

@fluffypony Then is it document's fault for this case? Code is reference for actively maintained project like here, but in my thought, document should be valid at same time.

fluffypony commented 7 years ago

@Kais-DkM we aren't connected to CryptoNote, and are far divorced from our CryptoNote origins. The inherited bits of code that still remain in the source tree are slowly being phased out (e.g. wire protocol is being replaced with ZMTP). I wouldn't rely on CryptoNote documentation to be a reflection of anything in Monero, because it isn't:)

remagpie commented 7 years ago

@fluffypony Oh, then maybe I should reopen issue in CryptoNote's repository. Closing this issue, and thank you for your response.

fluffypony commented 7 years ago

@Kais-DkM no problem, any time:)