Closed tkwilliams closed 1 week ago
Thank you for reporting this.
https://github.com/monero-project/monero/pull/9450
Duplicate. Closing it.
Not a duplicate actually. boost-1.85 broke SOME stuff, but boost-1.86 broke some entirely NEW STUFF. I don't see any mention in the #9450 thread addressing the new breakage , so I opened this as a new bug.
Oook, sorry if so. Lemme give it another try :)
the PR title should ideally be updated to make it more clear
Builds great when I apply it to master. Sadly, master and v0.18.3.4 have diverged pretty significantly (e.g. I can't just rebase v0.18.3.4 against master, then apply this, which would be needed to justify building a package). The packaging standards are averse to building straight from master - they prefer the pretense of "RELEASE + some git tag", which is of course NO MORE "stable" than just building from master to begin with, but what can you do :)
No worries, you folks will cut a new release soon enough and we can go from there.
Thanks for all the hard work!
@tkwilliams thanks for updating / reporting this issue.
Keeping this issue closed.
@tkwilliams there is also a release branch version of this PR open #9462 that should apply without issues
NICE! Fetching now :)
Thanks @selsta
On Sun, Sep 15, 2024 at 4:34 PM selsta @.***> wrote:
@tkwilliams https://github.com/tkwilliams there is also a release branch version of this PR open #9462 https://github.com/monero-project/monero/pull/9462 that should apply without issues
— Reply to this email directly, view it on GitHub https://github.com/monero-project/monero/issues/9485#issuecomment-2351783283, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPNS55CKF3EXD7OYDTGG5DZWXVORAVCNFSM6AAAAABOH4BNFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRG44DGMRYGM . You are receiving this because you were mentioned.Message ID: @.***>
Looks like boost added some data types in 1.86 which conflict with those defined in monero - example below.
Sadly, the distros (OpenSUSE in my case) have started pushing out boost-1.86 to their repos and this is of course breaking the package builds.
This built flawlessly against boost-1.85 of course, but backwards compat has always been a low priority for the boost devs :-/
Thanks!