monero-project / monero

Monero: the secure, private, untraceable cryptocurrency
https://getmonero.org
Other
9k stars 3.12k forks source link

trezor: vendor trezor-common #9491

Open tobtoht opened 1 month ago

tobtoht commented 1 month ago

Based on #9477.

Run ./src/device_trezor/trezor/fetch_protob.sh to compare.

da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768  ./COPYING
02182d39653d362e14e40b4d8e4a29e68959b25015f2b311e64c3854124d1831  ./messages-common.proto
d703cc79e03155646a930b837917a4f40e24413453d1f45924ed3c23212a1d33  ./messages-debug.proto
a5c07f7fb784e745aa2d918119b8a209e88e0b78b4b9354d3aa4614ac90f4ae2  ./messages-management.proto
20235c36b1a0fec625821ad8cc60908ca964a376a4cbe7a901fe9fcc668a9805  ./messages-monero.proto
b8574e3a591074920a1f97a2d85f851fe6e679158a943f3a6e4bf9b43ff29faa  ./messages.proto
iamamyth commented 1 month ago

This PR makes a lot of sense, conceptually: While vendoring normally avoids auto-including broken or malicious updates at the expense of receiving the latest bug/security patches, the protobuf files should rarely, if ever, change, and skipping changes to them doesn't introduce much risk (the most likely scenario would be a glaringly obvious protocol incompatibility).