Transaction proofs (InProofV1 and OutProofV1) have incomplete Schnorr challenges

monero-project / research-lab

A general repo for Monero Research Lab work in progress and completed work

244 stars 78 forks source link

Transaction proofs (InProofV1 and OutProofV1) have incomplete Schnorr challenges #60

Open SarangNoether opened 4 years ago

SarangNoether commented 4 years ago

It's possible to generate proofs for incoming and outgoing transactions of knowledge of either the transaction private key or the recipient private view key, using two-component Schnorr proofs. However, the challenge used in the proof generation and verification functions does not include all public proof parameters.

UkoeHB commented 4 years ago

EDIT: (moved to new issue)

SarangNoether commented 4 years ago

This would almost certainly be separate functionality from the existing proof functions.

SarangNoether commented 4 years ago

This issue specifically deals with the existing challenge construction, which is incomplete.

UkoeHB commented 4 years ago

Ah, I can make a separate issue then. Thought this was about 'proofs about tx info' in general.

SarangNoether commented 4 years ago

No worries. I'd prefer to keep it separate, to track the fix.

SarangNoether commented 4 years ago

Addressed in https://github.com/monero-project/monero/pull/6329.