monerodocs / md

Unofficial technical documentation for Monero cryptocurrency
https://monerodocs.org
MIT License
83 stars 61 forks source link

Add command line arguments to monero-wallet-rpc.reference.md and Add Dark Mode #37

Closed elibroftw closed 2 years ago

elibroftw commented 2 years ago
elibroftw commented 2 years ago

Also to whomever merges this, can you please add https://monerodocs.org/ to the repository's website field?

CryptoGrampy commented 2 years ago

Tested the dark mode on Chromium and Firefox. Looks amazing! Nice job @elibroftw

qertoip commented 2 years ago

Thanks so much for your PR! This is very much welcome.

Some background: this specific page (monero-wallet-rpc-reference) was originally auto-generated by transforming a relevant page from getmonero. As such it is lacking in consistency with other pages.

Kindly please:

On the organization side please:

Thanks again!

elibroftw commented 2 years ago

I don't agree with the full paths point. By providing a full path, we are sharing knowledge on where the wallet-rpc would reside on a server and where it would be on a development machine. The former is a recommendation to download and store monero binaries in ~/bin and the latter tells the developer the installation location of the monero binaries on windows, saving them the minute or so it takes to hunt it down themselves.

qertoip commented 2 years ago

Thanks for your comment!

The paths vary greatly across operating systems, Linux distributions, conventions and user preferences. I like the docs to be agnostic regarding the paths.

The default installation path under Windows can be covered on the Interacting / Overview page.

elibroftw commented 2 years ago

"Use default ports, in this case 18081"

The wallet-rpc does not have a default port. 18081 is for the daemon not the wallet-rpc. 28088 is best to use in order to stay consistent with the other docs.

qertoip commented 2 years ago

@elibroftw you are right, the 18081 is daemon RPC, scratch my remark regarding the ports.

elibroftw commented 2 years ago

Going to create new PR's

elibroftw commented 2 years ago

39 and #40