Closed elibroftw closed 2 years ago
Also to whomever merges this, can you please add https://monerodocs.org/ to the repository's website field?
Tested the dark mode on Chromium and Firefox. Looks amazing! Nice job @elibroftw
Thanks so much for your PR! This is very much welcome.
Some background: this specific page (monero-wallet-rpc-reference) was originally auto-generated by transforming a relevant page from getmonero. As such it is lacking in consistency with other pages.
Kindly please:
On the organization side please:
Thanks again!
I don't agree with the full paths point. By providing a full path, we are sharing knowledge on where the wallet-rpc would reside on a server and where it would be on a development machine. The former is a recommendation to download and store monero binaries in ~/bin and the latter tells the developer the installation location of the monero binaries on windows, saving them the minute or so it takes to hunt it down themselves.
Thanks for your comment!
The paths vary greatly across operating systems, Linux distributions, conventions and user preferences. I like the docs to be agnostic regarding the paths.
The default installation path under Windows can be covered on the Interacting / Overview page.
"Use default ports, in this case 18081"
The wallet-rpc does not have a default port. 18081 is for the daemon not the wallet-rpc. 28088 is best to use in order to stay consistent with the other docs.
@elibroftw you are right, the 18081 is daemon RPC, scratch my remark regarding the ports.
Going to create new PR's
--help
is used onmonero-wallet-rpc
.