search

monerodocs / md

Unofficial technical documentation for Monero cryptocurrency
https://monerodocs.org
MIT License
84 stars 59 forks source link

Subaddress generation algorithm description is outdated #4

Closed emesik closed 5 years ago

emesik commented 5 years ago

I was investigating that recently to implement subaddr generation. The algorithm described on monerodocs.org is outdated, probably originating from first proposal of such feature.

This answer on stackexchange describes the right version. And there's a nice JS implementation mentioned at the end.

qertoip commented 5 years ago

Thanks a lot! Will have a look on this.

emesik commented 5 years ago

Also, my implementation might be even easier to understand. The JS version used some complex types internally, while mine operates on integers (being ridiculously slow BTW).

qertoip commented 5 years ago

This is now fixed thanks to your clean Python implementation and the referenced stack exchange answer by knaccc. Thanks so much!