search

monerodocs / md

Unofficial technical documentation for Monero cryptocurrency
https://monerodocs.org
MIT License
84 stars 59 forks source link

Fix Dark Theme Footer and Code Snippet Color #41

Closed elibroftw closed 2 years ago

elibroftw commented 2 years ago

Previous image New image

qertoip commented 2 years ago

Thanks for playing with the footer!

It's a matter of taste but I think I like the original dark-blue color better. Maybe instead of normalizing to black we could adjust the header to the same dark-blue in the dark mode?

elibroftw commented 2 years ago

The blue was from the slate theme. I don't know about you, but it just looked too off. Otherwise I wouldn't have been so motivated to change it.

The contrast looks way worse when your actually on the website. The screenshots don't communicate that.

elibroftw commented 2 years ago

If by footer you meant only that small bar at the bottom, then yeah the dark blue could blend in properly. I just don't think the header would be a good idea then.

elibroftw commented 2 years ago

@qertoip so?

qertoip commented 2 years ago

I did some visual testing and decided to merge it as it is. Will be live soon. Thanks!