search

moneroexamples / transactions-export

Searches blockchain for your outputs and ring members using given address and view key.
BSD 3-Clause "New" or "Revised" License
26 stars 14 forks source link

tx_fee seems to be incorrect #36

Closed mightymoos3 closed 1 year ago

mightymoos3 commented 1 year ago

Recently the column tx_fee was added to xmr2csv, but I'm under the impression that the resulting numbers are incorrect. Here is a sample output when trying to export all transactions:

> head xmr_report.csv
Timestamp,Block_no,Tx_hash,Tx_public_key,Tx_version,Payment_id,Out_idx,Amount,Output_pub_key,Output_key_img,Output_spend,Tx_fee
1970-01-01 00:00:00,0,c88ce9783b4f11190d7b9c17a69c1c52200f9faaee8e98dd07e6811175177139,7767aafcde9be00dcfd098715ebcf7f410daebc582fda69d24a28e9d0bc890d1,1,0000000000000000000000000000000000000000000000000000000000000000,0,17592186044415,9b2e4c0281c0b02e7c53291a94d1d0cbff8883f8024f5142ee494ffbbd088071,0000000000000000000000000000000000000000000000000000000000000000,0,187651660023512
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,0,267200,5f391ad90e8b64ef432a0a28d0d9d699189b9c1322248ddbdb699c101a3cd9c3,0000000000000000000000000000000000000000000000000000000000000000,0,187651660023512

In both of these early transactions, the fee should have been 0, but it's 187651660023512 In other transactions, other large numbers appear, ~but so far I haven't found any that seem to be correct.~

Is anyone else experiencing this issue?

moneroexamples commented 1 year ago

The transactions are from mainnet or testnet?

mightymoos3 commented 1 year ago

mainnet

Here are some commands to reproduce: > ./xmr2csv -n 2 --all-outputs -c /tmp/xmr_report.csv > cat /tmp/xmr_report.csv

Timestamp,Block_no,Tx_hash,Tx_public_key,Tx_version,Payment_id,Out_idx,Amount,Output_pub_key,Output_key_img,Output_spend,Tx_fee
1970-01-01 00:00:00,0,c88ce9783b4f11190d7b9c17a69c1c52200f9faaee8e98dd07e6811175177139,7767aafcde9be00dcfd098715ebcf7f410daebc582fda69d24a28e9d0bc890d1,1,0000000000000000000000000000000000000000000000000000000000000000,0,17592186044415,9b2e4c0281c0b02e7c53291a94d1d0cbff8883f8024f5142ee494ffbbd088071,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,0,267200,5f391ad90e8b64ef432a0a28d0d9d699189b9c1322248ddbdb699c101a3cd9c3,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,1,9000000,33b81ac838467f7c59079e80517be1a45de51248a9bd841bf783e0aca7b2d5e2,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,2,60000000,3dc61a8cab11504ef1a36c51affeb7eed222cd09c98bf5045e489c23b409c9bc,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,3,100000000,2caa4a9af327b36df136599a104278cf44342b0732bb5ad8c4c3582531add94b,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,4,2000000000,f9edf7d361176a29d1ce53e890e6ebc1e721d9719d273b69f1eb15d96025c634,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,5,90000000000,2e5ba472765cb2297f51f1a47aaf5f358cf48e16593c25bfc1880578014a65ed,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,6,500000000000,1b82a36cde1c9a6103d99ea6ebfb9f82b2547cef8934d8e87cf5e20c098ede9c,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,7,7000000000000,b37974cac8678446a230fb3e1b0ec06d56666bf0bf43dd64ff096a01f5aa2fda,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272
2014-04-18 10:49:53,1,52578a3816ec18ca6db2ec4f594b7c8a778caa4c52d2c1705bcbab9798a9ea7b,2a9fca96074c5216f9622c58c5c95024e53ff579d128913548363cb14d7f6374,1,0000000000000000000000000000000000000000000000000000000000000000,8,10000000000000,a0c492751cb53389c9228f68b1ec1be831fb774a285f06c4ee02053858486e82,0000000000000000000000000000000000000000000000000000000000000000,0,187651411949272

In this run the number is actually 187651411949272, and it seems to change with each run.

Not every value is wrong though, as this example shows: > ./xmr2csv -t 2000000 -n 2 --all-outputs -c /tmp/xmr_report.csv > cat /tmp/xmr_report.csv

Timestamp,Block_no,Tx_hash,Tx_public_key,Tx_version,Payment_id,Out_idx,Amount,Output_pub_key,Output_key_img,Output_spend,Tx_fee
2019-12-30 04:29:54,2000000,eae25672906c24ee26d95221476010854a936d50c8bdcd7e7935defc46306c8b,f9b95f4fae7e4ce7192b78f9645a25307e93bdc510be558006cf65194d23d18c,2,0000000000000000000000000000000000000000000000000000000000000000,0,2040028039279,2ee15ed05f71cc4d3dda3d1f3fe7724af90c3dd15e5d1d7886d42639d0cc7be7,0000000000000000000000000000000000000000000000000000000000000000,0,187651361666776
2019-12-30 04:31:30,2000001,1ca848c7153783969ce5bebd7af7c9625c4c147face38f06f49b5cf451ed96cf,e6aff8ad97fb9f6cad5da22e0c16f864eb8eb3d98e244cb7e1b6fd9a25ca084a,2,0000000000000000000000000000000000000000000000000000000000000000,0,2040287018235,a8d7c38109850b3c5153165e730db14299b67c703358fbcad98da6b9296ae73b,0000000000000000000000000000000000000000000000000000000000000000,0,187651361666776
2019-12-30 04:31:30,2000001,e50d5754231bc044fce00ce611a644182b00147519d1adfd3281e5a6df5a8d44,39a93453437d79434f79a9721bc820438f26494d92166be6b381334a8aa90576,2,0000000000000000000000000000000000000000000000000000000000000000,0,0,c033d367856eb60ff1b44038f40100dfb2d9818038187460bab1bf9b03bfec45,0000000000000000000000000000000000000000000000000000000000000000,0,182040000
2019-12-30 04:31:30,2000001,e50d5754231bc044fce00ce611a644182b00147519d1adfd3281e5a6df5a8d44,39a93453437d79434f79a9721bc820438f26494d92166be6b381334a8aa90576,2,0000000000000000000000000000000000000000000000000000000000000000,1,0,adc7c3979d65cac84e8419f093ffdbd35d337ac5dfd21785c26cfd915b696860,0000000000000000000000000000000000000000000000000000000000000000,0,182040000
2019-12-30 04:31:30,2000001,a785a281989cf2c78da823ffe0bfd12fe9ccc61a0c810011565c8ee613682260,a5e5cea7f331c117c89e114489ae4d081f6483d77fda4159d363d3ecbdcbd8ba,2,0000000000000000000000000000000000000000000000000000000000000000,0,0,9f45d4e4cefe45a9723b0ee035584a2770f972595a110efea1e796c45e111b85,0000000000000000000000000000000000000000000000000000000000000000,0,56730000
2019-12-30 04:31:30,2000001,a785a281989cf2c78da823ffe0bfd12fe9ccc61a0c810011565c8ee613682260,a5e5cea7f331c117c89e114489ae4d081f6483d77fda4159d363d3ecbdcbd8ba,2,0000000000000000000000000000000000000000000000000000000000000000,1,0,acb4d641f94ee31346b9420e36281ff568e78cb7ba7661f53aa6953c0b9fb16c,0000000000000000000000000000000000000000000000000000000000000000,0,56730000
2019-12-30 04:31:30,2000001,a785a281989cf2c78da823ffe0bfd12fe9ccc61a0c810011565c8ee613682260,a5e5cea7f331c117c89e114489ae4d081f6483d77fda4159d363d3ecbdcbd8ba,2,0000000000000000000000000000000000000000000000000000000000000000,2,0,f57f1377598621392c8daad64abc622880ac18dead858f5fb9dbcfe93a6861db,0000000000000000000000000000000000000000000000000000000000000000,0,56730000
2019-12-30 04:31:30,2000001,a785a281989cf2c78da823ffe0bfd12fe9ccc61a0c810011565c8ee613682260,a5e5cea7f331c117c89e114489ae4d081f6483d77fda4159d363d3ecbdcbd8ba,2,0000000000000000000000000000000000000000000000000000000000000000,3,0,4bc9e5abf7d67aa18d28d17ba3f1a6ce387475340fd486f6ad8d6d8761e030d0,0000000000000000000000000000000000000000000000000000000000000000,0,56730000
2019-12-30 04:31:30,2000001,fcd177c77019cd5782c683ee99ec1e58f00bb27aa8e73f0073d32dc177a34d98,35e9910c4a04229124acc1d9e89e49c9bb03dbda3ab3d3be2c7c15c1d682ecbc,2,0000000000000000000000000000000000000000000000000000000000000000,0,0,5049b6c2eb66846c83b7a7276e57759ff36d3dfb28cdc1abe2f7b211813d94bd,0000000000000000000000000000000000000000000000000000000000000000,0,24100000
2019-12-30 04:31:30,2000001,fcd177c77019cd5782c683ee99ec1e58f00bb27aa8e73f0073d32dc177a34d98,35e9910c4a04229124acc1d9e89e49c9bb03dbda3ab3d3be2c7c15c1d682ecbc,2,0000000000000000000000000000000000000000000000000000000000000000,1,0,5dc6c19b8546ce0db50e4e5a078b8f46d75bb75847845707c55da7ed1e1d22f9,0000000000000000000000000000000000000000000000000000000000000000,0,24100000

Here is another example where only two different Tx_fees are being reported for 5 transactions in a block, where a block explorer says there should be 4 unique values (0, 5000000000, 5870000000 and 9630000000): > ./xmr2csv -t 120570 -n 1 --all-outputs -c /tmp/xmr_report.csv > cat /tmp/xmr_report.csv | cut -d ',' -f12 | sort -r | uniq

Tx_fee
281474885450552
187650619111128
moneroexamples commented 1 year ago

Can you check now? I pushed a fix to master branch.

https://github.com/moneroexamples/transactions-export/commit/1aa380186228799104919c13d65238df7410aa3f

mightymoos3 commented 1 year ago

This seems to solve the issue! Thank you!