search

monet / monet.js

monet.js - Monadic types library for JavaScript
https://monet.github.io/monet.js/
MIT License
1.6k stars 114 forks source link

Maybe.fromEmpty is not yet added to src/monet.d.ts #228

Closed xanonid closed 2 years ago

xanonid commented 4 years ago

Maybe.fromEmpty is implemented, but not yet listed in src/monet.d.ts.

doktor500 commented 2 years ago

Hi, could this be added and released?

ulfryk commented 2 years ago

@doktor500 I'm not sure when I'll have time to do it.. and there's not much more people here that try to maintain this library 🙈

tomecko commented 2 years ago

I can prepare release of 0.9.3 if the above change gets merged.

ulfryk commented 2 years ago

@tomecko done :)

tomecko commented 2 years ago

I believe I've done what was possible for me to do. The rest (e.g. tagging, creating release in GH, publishing) lies in the hands of maintainer @ulfryk

doktor500 commented 2 years ago

Great, @ulfryk would you mind releasing this version to npm?

ulfryk commented 2 years ago

@doktor500 @tomecko it should have automatically release after merge :(

I don't have time to investigate now, sorry

ulfryk commented 2 years ago

but snapshot with this functionality was automatically released with version 0.9.2-479

doktor500 commented 2 years ago

It seems that the changes were merged to the develop branch but they still need to be merged to the master branch in order to create a version on npm with the right tag (0.9.3) would you mind merging those changes to master and see if that automatically creates the new release on npm with the right version tag?

doktor500 commented 2 years ago

Basically merging this PR https://github.com/monet/monet.js/pull/248

ulfryk commented 2 years ago

Exactly, thanks, sorry for all delays:

A new version of the package monet (0.9.3) was published at 2021-11-15T18:04:01.737Z from
34.66.200.49. The shasum of this package was b296747d5dc6dc13f51b4c7e85ed01d787b031a1.

🎉

doktor500 commented 2 years ago

Brilliant! Thanks so much, @ulfryk and @tomecko 👏