search

moneyadviceservice / dough

Reusable UI components
http://www.madewithdough.org.uk/
MIT License
9 stars 1 forks source link

Update rails for fincap #300

Closed tomas-stefano closed 6 years ago

tomas-stefano commented 6 years ago

No TP cards but it is blocking the fincap since this PR

This gem was added to Fincap here but it was raising the errors that Dough was not compatible with Rails 5.

So this PR addresses the Rails 5 update and fix for it which is explained on the commit message.

tomas-stefano commented 6 years ago

I think the history of this PR is in a clean state because it describes the attempt to upgrade, the fixes for compatibility (which luckily it was a simple fix rather than a complex list of fixes) and the version bump of Dough.

johnplayer1982 commented 6 years ago

:+1: