search

moneyadviceservice / dough

Reusable UI components
http://www.madewithdough.org.uk/
MIT License
9 stars 1 forks source link

9847 modify dough component #303

Closed willhall88 closed 5 years ago

willhall88 commented 5 years ago

https://moneyadviceservice.tpondemand.com/entity/9847-modify-doughbasecomponent

This is one piece of work being done to update the Dough gem.

Adding an index attribute for each DoughBase Component makes it a lot harder for these instances to be referenced and called. The other part of the work in this ticket was to publish events on the success/failure of component initalization.

We've started off with having event strings being stored in once central location as constants. We had a long discussion over the best way of implementing these, firstly for performance (with minification), secondly as to the best place for each of these events to be stored - along with the best convention to use for these.

Please feel free to comment on this approach and if you feel like there may be a nicer solution

nkmdk-007 commented 5 years ago

@willhall88 , @davidtrussler - We need to close this Master PR and create a new one against the new https://github.com/moneyadviceservice/dough/tree/fe-architecture - We will need to keep this new branch updated from Master but it acts as a main feature branch for each of the user stories within the Target Process Feature.

willhall88 commented 5 years ago

@nmiddleweek I've just reopened this and changed the base branch to the fe-architecture. That way the context of this PR is kept and not lost by opening a new PR