masbuild
commented
5 years ago | 1 Error | ||||
|---|---|---|---|---|
| :no_entry_sign: |
|
| 2 Warnings | |
|---|---|
| :warning: | There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior. If this is a refactor PR, please ignore the message.Refer to our mas standards guides about opening a PRhere |
| :warning: | English locale contains keys missing in Welsh locale. Missing keys: [“taken”, “taken”]. |
At Money Advice Service, we use Danger gem, to ensure that our commits and pull requests follow standards. If you think one of the points here has been raised in error (or shouldn't be in our standards), open an issue or pull request on our Danger config.
Generated by :no_entry_sign: Danger
TP10188
The recently updated i icons are displaying badly on the Stamp Duty Calculator tool. It is positioned wrongly and the width of the overlay is essentially zero.
This is caused by the component dynamically setting its position and size relative to the icon itself.
The solution in this PR is to set these values relative to the parent of the icon that is a more reliable reference.