moneyadviceservice / dough

Reusable UI components
http://www.madewithdough.org.uk/
MIT License
9 stars 1 forks source link

Revert "10188 sdc icon misaligned position fix" #314

Closed davidtrussler closed 5 years ago

davidtrussler commented 5 years ago

Reverts moneyadviceservice/dough#313

Need to apply a further fix.

masbuild commented 5 years ago
1 Error
:no_entry_sign:
lib/dough/version.rb 2 Style/MutableConstant: Freeze mutable objects assigned to constants.

3 Warnings
:warning: There is no Targetprocess ticket associated to this PR. Please include the link to the corresponding task (TP-XXXX). If no ticket matches these changes consider creating one and linking it here.
:warning: There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior. If this is a refactor PR, please ignore the message.Refer to our mas standards guides about opening a PRhere
:warning: English locale contains keys missing in Welsh locale. Missing keys: [“taken”, “taken”].

At Money Advice Service, we use Danger gem, to ensure that our commits and pull requests follow standards. If you think one of the points here has been raised in error (or shouldn't be in our standards), open an issue or pull request on our Danger config.

Generated by :no_entry_sign: Danger