masbuild
commented
5 years ago | 1 Error | ||||
|---|---|---|---|---|
| :no_entry_sign: |
|
| 2 Warnings | |
|---|---|
| :warning: | There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior. If this is a refactor PR, please ignore the message.Refer to our mas standards guides about opening a PRhere |
| :warning: | English locale contains keys missing in Welsh locale. Missing keys: [“taken”, “taken”]. |
At Money Advice Service, we use Danger gem, to ensure that our commits and pull requests follow standards. If you think one of the points here has been raised in error (or shouldn't be in our standards), open an issue or pull request on our Danger config.
Generated by :no_entry_sign: Danger
TP10188
A further minor fix for the popup tip component.
The tabindex property isn't required here and causes some odd scroll problems in some tools. As long as the focus moves into the overlay it allows the user to tab into the close button as required for accessibility reasons.