search

moneyadviceservice / dough

Reusable UI components
http://www.madewithdough.org.uk/
MIT License
9 stars 1 forks source link

Rails 5 #337

Closed kiggundu closed 4 years ago

kiggundu commented 4 years ago

PR for original changes to migrate dough to Rails 5

kiggundu commented 4 years ago

All 63 tests are passing locally so not sure why some are failing on travis box. Looking into it :-(

masbuild commented 4 years ago
2 Warnings
:warning: There is no Targetprocess ticket associated to this PR. Please include the link to the corresponding task (TP-XXXX). If no ticket matches these changes consider creating one and linking it here.
:warning: English locale contains keys missing in Welsh locale. Missing keys: [“taken”, “taken”].

At Money Advice Service, we use Danger gem, to ensure that our commits and pull requests follow standards. If you think one of the points here has been raised in error (or shouldn't be in our standards), open an issue or pull request on our Danger config.

Generated by :no_entry_sign: Danger