moneyadviceservice / dough

Reusable UI components
http://www.madewithdough.org.uk/
MIT License
9 stars 1 forks source link

12213 third party cookies update link #343

Closed davidtrussler closed 3 years ago

davidtrussler commented 3 years ago

TP-12213

This work essentially replaces a link added in a previous piece of work (TP-11920) to provide users of syndicated tools with a means of continuing to use a tool when their browser blocks the use of third party cookies. Originally that referred users to the partner-tools sub-domain but that was not always a great experience for the user and not really a correct use of that sub-domain. In this work we are dynamically generating a URL to the tool on the MAS site instead.

This PR also requires PR-2329 on frontend to deploy it to the Credit Card Calculator.

masbuild commented 3 years ago
2 Warnings
:warning: There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior. If this is a refactor PR, please ignore the message.Refer to our mas standards guides about opening a PRhere
:warning: English locale contains keys missing in Welsh locale. Missing keys: ["taken", "taken"].

At Money Advice Service, we use Danger gem, to ensure that our commits and pull requests follow standards. If you think one of the points here has been raised in error (or shouldn't be in our standards), open an issue or pull request on our Danger config.

Generated by :no_entry_sign: Danger