search

moneybutton / bsv

Bitcoin SV javascript library
Other
204 stars 105 forks source link

rename bip32 to HDWallet and bip39 to Mnemonic #258

Open Zhell1 opened 1 year ago

Zhell1 commented 1 year ago

related issue: https://github.com/moneybutton/bsv/issues/253

functions should be easy to understand and access from their functional name, which is more important than arbitrary naming schemes

using bips as the naming scheme is confusing to newcomers (see related issue) and fails at the target purpose of: It should not be necessary to read the source code of a class or function to know how to use it / so that other developers find the code easy to understand.

developers, especially newcomers, should not have to learn by heart which BIP number corresponds to a well-known feature of any bitcoin library, the feature should be described by its name for clarity and ease of use

before:

bsv.Bip32
bsv.Bip39

after:

bsv.HDWallet
bsv.Mnemonic
mathiasrw commented 1 year ago

This makes so much sense. Please merge.