search

moneybutton / bsv

Bitcoin SV javascript library
Other
204 stars 107 forks source link

about version guard #74

Closed monkeylord closed 5 years ago

monkeylord commented 5 years ago

It seems that the version guard error is quite annoying when requiring multiple modules that depend on bsv.

More than one instance of bsv found. Please make sure to require bsv and check that submodules do not also include their own bsv dependency.

  1. Should we change the error to a warning?
  2. Should there be a global bsv instance?

Maybe we should change version guard in index.js, by using a global bsv instance in somewhere like global._bsvInstance ?

bitcartel commented 5 years ago

This issue is closed by PR https://github.com/moneybutton/bsv/pull/86 which has merged.