search

moneybutton / yours-core

Client-side key and content management for Yours.
https://www.yours.network
MIT License
132 stars 27 forks source link

dattcore: Make asynchronous version of bip32 to/from JSON #47

Closed ryanxcharles closed 8 years ago

ryanxcharles commented 9 years ago

Right now we're using a hex version of bip32 keys to send them to/from works and store/retrieve from database. Unfortunately this is a blocking operation because converting compressed pubkeys to a pubkey requires elliptic curve math. We need to implement asynchronous to/from JSON methods so this stuff doesn't block. When we do this, we could also consider using base58check instead of hex, which is the standard way to represent bip32 keys (xprv/xpub).

ryanxcharles commented 8 years ago

fullnode now supports this with the .toFastBuffer and .fromFastBuffer. This was fixed in Datt with a series of commits, particularly from 8b4dd5c to 617e7e7