moneyhub / moneyhub-api-client

Node.JS Client for the Moneyhub API
10 stars 7 forks source link

Allow for permissions to be set in auth requests #19

Closed gillyhl closed 3 years ago

gillyhl commented 3 years ago

Sets the permissions in the auth request body when creating an auth request.

gillyhl commented 3 years ago

It looks good but could we also allow passing permissions for the following methods:

Are we able to let the permissions just be part of the claims object they set in the method? Or do we want them to pass in permissions as a separate argument and we include it in the claims for them?

ozamarripa commented 3 years ago

I think that it would be good to have an optional parameter that will include the permissions in the claims object if provided, api clients will always have the option to pass the whole claims object if needed