moneyhub / moneyhub-api-client

Node.JS Client for the Moneyhub API
10 stars 7 forks source link

Typescript rewrite #27

Open jamiehaywood opened 2 years ago

jamiehaywood commented 2 years ago

This is a first pass at rewriting the whole library in TS.

If you want immediate utility out of this PR, you could cherry pick commit 59e19b0 which has 90% of all the type declarations in a types folder which mirror the existing JS structure. All you would need to do is add a "types" key to the package.json file and point at the types folder.

Otherwise, things still TODO:

davidgtonge commented 2 years ago

Wow, thanks @jamiehaywood

ozamarripa commented 2 years ago

This looks pretty good! Out of curiosity, how come you changed the test to use Jest?

jamiehaywood commented 2 years ago

@ozamarripa a couple of reasons for picking Jest, but the main ones are: